Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update egui with less wgpu lifetimes #7509

Merged
merged 5 commits into from
Sep 25, 2024
Merged

Update egui with less wgpu lifetimes #7509

merged 5 commits into from
Sep 25, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented Sep 25, 2024 •
edited by github-actions bot
Loading

@Wumpf you had a pretty solid repro of this yesterday - please test 🙏

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@emilk emilk added dependencies concerning crates, pip packages etc exclude from changelog PRs with this won't show up in CHANGELOG.md egui Requires egui/eframe work labels Sep 25, 2024
@emilk emilk requested a review from Wumpf September 25, 2024 09:36
@emilk emilk changed the title Update egui with fix for tooltip shrinkage Update egui with fix for tooltip/menu shrinkage Sep 25, 2024
@emilk emilk changed the title Update egui with fix for tooltip/menu shrinkage Update egui with less wgpu lifetimes Sep 25, 2024
emilk
emilk commented Sep 25, 2024
View reviewed changes
Copy link
Member Author

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice wgpu cleanup!

crates/viewer/re_renderer/src/queueable_draw_data.rs Outdated Show resolved Hide resolved
@emilk
Copy link
Member Author

emilk commented Sep 25, 2024

@Wumpf says on slack that #6801 is still a problem:

image

and that happens both with pixels_per_point=1 and 2

Wumpf
Wumpf approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixing up lifetime names, then good to merge regardless of its ability to fix the tooltip issue

@Wumpf Wumpf merged commit 56b689d into main Sep 25, 2024
6 of 13 checks passed
@Wumpf Wumpf deleted the emilk/update-egui-fix-toolbar-shrinkage branch September 25, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
dependencies concerning crates, pip packages etc egui Requires egui/eframe work exclude from changelog PRs with this won't show up in CHANGELOG.md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emilk @Wumpf